TypeHelper.cpp

Go to the documentation of this file.

//===-- TypeHelper.cpp ------------------------------------------*- C++ -*-===//
//
// Part of the LLZK Project, under the Apache License v2.0.
// See LICENSE.txt for license information.
// Copyright 2025 Veridise Inc.
// SPDX-License-Identifier: Apache-2.0
//
//===----------------------------------------------------------------------===//
 
#include "llzk/Util/TypeHelper.h"
 
#include "llzk/Dialect/Array/IR/Types.h"
#include "llzk/Dialect/Felt/IR/Attrs.h"
#include "llzk/Dialect/Felt/IR/Types.h"
#include "llzk/Dialect/LLZK/IR/AttributeHelper.h"
#include "llzk/Dialect/POD/IR/Attrs.h"
#include "llzk/Dialect/POD/IR/Types.h"
#include "llzk/Dialect/Polymorphic/IR/Types.h"
#include "llzk/Dialect/String/IR/Types.h"
#include "llzk/Dialect/Struct/IR/Types.h"
#include "llzk/Util/Compare.h"
#include "llzk/Util/Debug.h"
#include "llzk/Util/StreamHelper.h"
#include "llzk/Util/SymbolHelper.h"
#include "llzk/Util/Walk.h"
 
#include <llvm/ADT/STLExtras.h>
#include <llvm/ADT/SmallVector.h>
#include <llvm/ADT/TypeSwitch.h>
#include <llvm/Support/Debug.h>
 
#include <cstdint>
#include <numeric>
 
#define DEBUG_TYPE "llzk-type-helpers"
 
using namespace mlir;
 
namespace llzk {
 
using namespace array;
using namespace component;
using namespace felt;
using namespace polymorphic;
using namespace string;
using namespace pod;

template <typename Derived, typename ResultType> struct LLZKTypeSwitch {
  inline ResultType match(Type type) {
    return llvm::TypeSwitch<Type, ResultType>(type)
        .template Case<IndexType>([this](auto t) {
      return static_cast<Derived *>(this)->caseIndex(t);
    })
        .template Case<FeltType>([this](auto t) {
      return static_cast<Derived *>(this)->caseFelt(t);
    })
        .template Case<StringType>([this](auto t) {
      return static_cast<Derived *>(this)->caseString(t);
    })
        .template Case<TypeVarType>([this](auto t) {
      return static_cast<Derived *>(this)->caseTypeVar(t);
    })
        .template Case<ArrayType>([this](auto t) {
      return static_cast<Derived *>(this)->caseArray(t);
    })
        .template Case<StructType>([this](auto t) {
      return static_cast<Derived *>(this)->caseStruct(t);
    }).template Case<PodType>([this](auto t) {
      return static_cast<Derived *>(this)->casePod(t);
    }).template Case<NoneType>([this](auto t) {
      return static_cast<Derived *>(this)->caseNone(t);
    }).Default([this](Type t) {
      if (t.isSignlessInteger(1)) {
        return static_cast<Derived *>(this)->caseBool(cast<IntegerType>(t));
      } else {
        return static_cast<Derived *>(this)->caseInvalid(t);
      }
    });
  }
 
private:
  friend Derived;
  LLZKTypeSwitch() = default;
};
 
void BuildShortTypeString::appendSymName(StringRef str) {
  if (str.empty()) {
    ss << '?';
  } else {
    ss << '@' << str;
  }
}
 
void BuildShortTypeString::appendSymRef(SymbolRefAttr sa) {
  appendSymName(sa.getRootReference().getValue());
  for (FlatSymbolRefAttr nestedRef : sa.getNestedReferences()) {
    ss << "::";
    appendSymName(nestedRef.getValue());
  }
}
 
BuildShortTypeString &BuildShortTypeString::append(Type type) {
  struct Impl : LLZKTypeSwitch<Impl, void> {
    BuildShortTypeString &outer;
    Impl(BuildShortTypeString &outerRef) : outer(outerRef) {}
 
    void caseInvalid(Type) { outer.ss << "!INVALID"; }
    void caseNone(NoneType) { outer.ss << 'n'; }
    void caseBool(IntegerType) { outer.ss << 'b'; }
    void caseIndex(IndexType) { outer.ss << 'i'; }
    void caseFelt(FeltType) { outer.ss << 'f'; }
    void caseString(StringType) { outer.ss << 's'; }
    void caseTypeVar(TypeVarType t) {
      outer.ss << "!t<";
      outer.appendSymName(llvm::cast<TypeVarType>(t).getRefName());
      outer.ss << '>';
    }
    void caseArray(ArrayType t) {
      outer.ss << "!a<";
      outer.append(t.getElementType());
      outer.ss << ':';
      outer.append(t.getDimensionSizes());
      outer.ss << '>';
    }
    void casePod(PodType t) {
      outer.ss << "!r<";
      for (auto record : t.getRecords()) {
        outer.appendSymRef(record.getNameSym());
      }
      outer.ss << '>';
    }
    void caseStruct(StructType t) {
      outer.ss << "!s<";
      outer.appendSymRef(t.getNameRef());
      if (ArrayAttr params = t.getParams()) {
        outer.ss << '_';
        outer.append(params.getValue());
      }
      outer.ss << '>';
    }
  };
  Impl(*this).match(type);
  return *this;
}
 
BuildShortTypeString &BuildShortTypeString::append(Attribute a) {
  assert(a && "BuildShortTypeString requires non-null attributes");
 
  // Adapted from AsmPrinter::Impl::printAttributeImpl()
  if (auto ia = llvm::dyn_cast<IntegerAttr>(a)) {
    Type ty = ia.getType();
    bool isUnsigned = ty.isUnsignedInteger() || ty.isSignlessInteger(1);
    ia.getValue().print(ss, !isUnsigned);
  } else if (auto fa = llvm::dyn_cast<FeltConstAttr>(a)) {
    ss << "f<";
    fa.getRawValue().print(ss);
    if (StringAttr fieldName = fa.getFieldName()) {
      // The byte length prevents field delimiters from colliding with adjacent parameters. For
      // example, `a>_f<36:b` followed by 37 and `a` followed by `b>_f<37` would otherwise render
      // the same concatenated short string.
      ss << ':' << fieldName.getValue().size() << ':' << fieldName.getValue();
    }
    ss << '>';
  } else if (auto sra = llvm::dyn_cast<SymbolRefAttr>(a)) {
    appendSymRef(sra);
  } else if (auto ta = llvm::dyn_cast<TypeAttr>(a)) {
    append(ta.getValue());
  } else if (auto ama = llvm::dyn_cast<AffineMapAttr>(a)) {
    ss << "!m<";
    // Filter to remove spaces from the affine_map representation
    filtered_raw_ostream fs(ss, [](char c) { return c == ' '; });
    ama.getValue().print(fs);
    fs.flush();
    ss << '>';
  } else if (auto aa = llvm::dyn_cast<ArrayAttr>(a)) {
    append(aa.getValue());
  } else {
    // All valid/legal cases must be covered above
    assertValidAttrForParamOfType(a);
  }
  return *this;
}
 
BuildShortTypeString &BuildShortTypeString::append(ArrayRef<Attribute> attrs) {
  llvm::interleave(attrs, ss, [this](Attribute a) { append(a); }, "_");
  return *this;
}
 
namespace {
 
template <typename... Types> class TypeList {

  template <typename StreamType> struct Appender {
 
    // single
    template <typename Ty> static inline void append(StreamType &stream) {
      stream << '\'' << Ty::name << '\'';
    }
 
    // multiple
    template <typename First, typename Second, typename... Rest>
    static void append(StreamType &stream) {
      append<First>(stream);
      stream << ", ";
      append<Second, Rest...>(stream);
    }
 
    // full list with wrapping brackets
    static inline void append(StreamType &stream) {
      stream << '[';
      append<Types...>(stream);
      stream << ']';
    }
  };
 
public:
  // Checks if the provided value is an instance of any of `Types`
  template <typename T> static inline bool matches(const T &value) {
    return llvm::isa_and_present<Types...>(value);
  }
 
  static void reportInvalid(EmitErrorFn emitError, const Twine &foundName, const char *aspect) {
    InFlightDiagnosticWrapper diag = emitError().append(aspect, " must be one of ");
    Appender<InFlightDiagnosticWrapper>::append(diag);
    diag.append(" but found '", foundName, '\'').report();
  }
 
  static inline void reportInvalid(EmitErrorFn emitError, Attribute found, const char *aspect) {
    if (emitError) {
      reportInvalid(emitError, found ? found.getAbstractAttribute().getName() : "nullptr", aspect);
    }
  }
 
  // Returns a comma-separated list formatted string of the names of `Types`
  static inline std::string getNames() {
    return buildStringViaCallback(Appender<llvm::raw_string_ostream>::append);
  }
};

template <class... Ts> struct make_unique {
  using type = TypeList<Ts...>;
};
 
template <class... Ts> struct make_unique<TypeList<>, Ts...> : make_unique<Ts...> {};
 
template <class U, class... Us, class... Ts>
struct make_unique<TypeList<U, Us...>, Ts...>
    : std::conditional_t<
          (std::is_same_v<U, Us> || ...) || (std::is_same_v<U, Ts> || ...),
          make_unique<TypeList<Us...>, Ts...>, make_unique<TypeList<Us...>, Ts..., U>> {};
 
template <class... Ts> using TypeListUnion = typename make_unique<Ts...>::type;
 
// Dimensions in the ArrayType must be one of the following:
//  - Integer constants
//  - SymbolRef (flat ref for struct params, non-flat for global constants from another module)
//  - AffineMap (for array created within a loop where size depends on loop variable)
using ArrayDimensionTypes = TypeList<IntegerAttr, SymbolRefAttr, AffineMapAttr>;
 
// Parameters in the StructType must be one of the following:
//  - Integer constants
//  - Field element constants
//  - SymbolRef (flat ref for struct params, non-flat for global constants from another module)
//  - Type
//  - AffineMap (for array of non-homogeneous structs)
using StructParamTypes =
    TypeList<IntegerAttr, FeltConstAttr, SymbolRefAttr, TypeAttr, AffineMapAttr>;
 
class AllowedTypes {
  struct ColumnCheckData {
    SymbolTableCollection *symbolTable = nullptr;
    Operation *op = nullptr;
  };
 
  bool no_felt : 1 = false;
  bool no_string : 1 = false;
  bool no_struct : 1 = false;
  bool no_array : 1 = false;
  bool no_pod : 1 = false;
  bool no_var : 1 = false;
  bool no_int : 1 = false;
  bool no_struct_params : 1 = false;
  bool must_be_column : 1 = false;
  bool type_var_free : 1 = false;
 
  ColumnCheckData columnCheck;

  bool validColumns(StructType s) {
    if (!must_be_column) {
      return true;
    }
    assert(columnCheck.symbolTable);
    assert(columnCheck.op);
    return succeeded(s.hasColumns(*columnCheck.symbolTable, columnCheck.op));
  }
 
public:
  constexpr AllowedTypes &noFelt() {
    no_felt = true;
    return *this;
  }
 
  constexpr AllowedTypes &noString() {
    no_string = true;
    return *this;
  }
 
  constexpr AllowedTypes &noStruct() {
    no_struct = true;
    return *this;
  }
 
  constexpr AllowedTypes &noArray() {
    no_array = true;
    return *this;
  }
 
  constexpr AllowedTypes &noPod() {
    no_pod = true;
    return *this;
  }
 
  constexpr AllowedTypes &noVar() {
    no_var = true;
    return *this;
  }
 
  constexpr AllowedTypes &noInt() {
    no_int = true;
    return *this;
  }
 
  constexpr AllowedTypes &noStructParams(bool noStructParams = true) {
    no_struct_params = noStructParams;
    return *this;
  }
 
  constexpr AllowedTypes &typeVarFree() {
    no_var = true;
    type_var_free = true;
    return *this;
  }
 
  constexpr AllowedTypes &onlyInt() {
    no_int = false;
    return noFelt().noString().noStruct().noArray().noPod().noVar();
  }
 
  constexpr AllowedTypes &mustBeColumn(SymbolTableCollection &symbolTable, Operation *op) {
    must_be_column = true;
    columnCheck.symbolTable = &symbolTable;
    columnCheck.op = op;
    return *this;
  }
 
  // This is the main check for allowed types.
  bool isValidTypeImpl(Type type);
 
  bool areValidArrayDimSizes(ArrayRef<Attribute> dimensionSizes, EmitErrorFn emitError = nullptr) {
    // In LLZK, the number of array dimensions must always be known, i.e., `hasRank()==true`
    if (dimensionSizes.empty()) {
      if (emitError) {
        emitError().append("array must have at least one dimension").report();
      }
      return false;
    }
    // Rather than immediately returning on failure, we check all dimensions and aggregate to
    // provide as many errors are possible in a single verifier run.
    bool success = true;
    for (Attribute a : dimensionSizes) {
      if (!ArrayDimensionTypes::matches(a)) {
        ArrayDimensionTypes::reportInvalid(emitError, a, "Array dimension");
        success = false;
      } else if (no_var && !type_var_free && !llvm::isa_and_present<IntegerAttr>(a)) {
        TypeList<IntegerAttr>::reportInvalid(emitError, a, "Concrete array dimension");
        success = false;
      } else if (failed(verifyAffineMapAttrType(emitError, a))) {
        success = false;
      } else if (failed(verifyIntAttrType(emitError, a))) {
        success = false;
      }
    }
    return success;
  }
 
  bool isValidArrayElemTypeImpl(Type type) {
    // ArrayType element can be any valid type sans ArrayType itself. Additionally, `NoneType`
    // is permitted for shape-only arrays that carry no element payload.
    return llvm::isa<NoneType>(type) || (!llvm::isa<ArrayType>(type) && isValidTypeImpl(type));
  }
 
  bool isValidArrayTypeImpl(
      Type elementType, ArrayRef<Attribute> dimensionSizes, EmitErrorFn emitError = nullptr
  ) {
    if (!areValidArrayDimSizes(dimensionSizes, emitError)) {
      return false;
    }
 
    // Ensure array element type is valid
    if (!isValidArrayElemTypeImpl(elementType)) {
      if (emitError) {
        // Print proper message if `elementType` is not a valid LLZK type or
        //  if it's simply not the right kind of type for an array element.
        if (succeeded(checkValidType(emitError, elementType))) {
          emitError()
              .append(
                  '\'', ArrayType::name, "' element type cannot be '",
                  elementType.getAbstractType().getName(), '\''
              )
              .report();
        }
      }
      return false;
    }
    return true;
  }
 
  bool isValidArrayTypeImpl(Type type) {
    if (ArrayType arrTy = llvm::dyn_cast<ArrayType>(type)) {
      return isValidArrayTypeImpl(arrTy.getElementType(), arrTy.getDimensionSizes());
    }
    return false;
  }
 
  // Note: The `no*` flags here refer to Types nested within a TypeAttr parameter (if any) except
  // for the `no_struct_params` flag which requires that `params` is null or empty.
  bool areValidStructTypeParams(ArrayAttr params, EmitErrorFn emitError = nullptr) {
    if (isNullOrEmpty(params)) {
      return true;
    }
    if (no_struct_params) {
      return false;
    }
    bool success = true;
    for (Attribute p : params) {
      if (!StructParamTypes::matches(p)) {
        StructParamTypes::reportInvalid(emitError, p, "Struct parameter");
        success = false;
      } else if (IntegerAttr i = llvm::dyn_cast<IntegerAttr>(p); i && isDynamic(i)) {
        if (emitError) {
          emitError().append("wildcard '?' is not allowed as struct type parameter").report();
        }
        success = false;
      } else if (TypeAttr tyAttr = llvm::dyn_cast<TypeAttr>(p)) {
        if (!isValidTypeImpl(tyAttr.getValue())) {
          if (emitError) {
            emitError().append("expected a valid LLZK type but found ", tyAttr.getValue()).report();
          }
          success = false;
        }
      } else if (type_var_free && llvm::isa<SymbolRefAttr>(p)) {
        TypeList<IntegerAttr, FeltConstAttr, TypeAttr, AffineMapAttr>::reportInvalid(
            emitError, p, "Type-variable-free struct parameter"
        );
        success = false;
      } else if (no_var && !type_var_free && !llvm::isa<IntegerAttr, FeltConstAttr>(p)) {
        TypeList<IntegerAttr>::reportInvalid(emitError, p, "Concrete struct parameter");
        success = false;
      } else if (failed(verifyAffineMapAttrType(emitError, p))) {
        success = false;
      } else if (failed(verifyIntAttrType(emitError, p))) {
        success = false;
      }
    }
 
    return success;
  }
 
  bool areValidPodRecords(ArrayRef<RecordAttr> records) {
    return llvm::all_of(records, [this](auto record) { return isValidTypeImpl(record.getType()); });
  }
};
 
bool AllowedTypes::isValidTypeImpl(Type type) {
  assert(
      !(no_int && no_felt && no_string && no_var && no_struct && no_array && no_pod) &&
      "All types have been deactivated"
  );
  struct Impl : LLZKTypeSwitch<Impl, bool> {
    AllowedTypes &outer;
    Impl(AllowedTypes &outerRef) : outer(outerRef) {}
 
    bool caseBool(IntegerType t) { return !outer.no_int && t.isSignlessInteger(1); }
    bool caseIndex(IndexType) { return !outer.no_int; }
    bool caseFelt(FeltType) { return !outer.no_felt; }
    bool caseString(StringType) { return !outer.no_string; }
    bool caseTypeVar(TypeVarType) { return !outer.no_var; }
    bool caseArray(ArrayType t) {
      return !outer.no_array &&
             outer.isValidArrayTypeImpl(t.getElementType(), t.getDimensionSizes());
    }
    bool casePod(PodType t) { return !outer.no_pod && outer.areValidPodRecords(t.getRecords()); }
    bool caseStruct(StructType t) {
      // Note: The `no*` flags here refer to Types nested within a TypeAttr parameter.
      if (outer.no_struct || !outer.validColumns(t)) {
        return false;
      }
      return !outer.no_struct && outer.areValidStructTypeParams(t.getParams());
    }
    bool caseNone(NoneType) { return false; }
    bool caseInvalid(Type) { return false; }
  };
  return Impl(*this).match(type);
}
 
} // namespace
 
bool isValidType(Type type) { return AllowedTypes().isValidTypeImpl(type); }
 
bool isValidColumnType(Type type, SymbolTableCollection &symbolTable, Operation *op) {
  return AllowedTypes().noString().noInt().mustBeColumn(symbolTable, op).isValidTypeImpl(type);
}
 
bool isValidGlobalType(Type type) { return AllowedTypes().noVar().isValidTypeImpl(type); }
 
bool isValidEmitEqType(Type type) {
  return AllowedTypes().noString().noStruct().isValidTypeImpl(type);
}
 
// Allowed types must be a subset of StructParamTypes (defined below)
bool isValidConstReadType(Type type) {
  return AllowedTypes().noString().noStruct().noArray().noPod().isValidTypeImpl(type);
}
 
bool isValidArrayElemType(Type type) { return AllowedTypes().isValidArrayElemTypeImpl(type); }
 
bool isValidArrayType(Type type) { return AllowedTypes().isValidArrayTypeImpl(type); }
 
bool isConcreteType(Type type, bool allowStructParams) {
  return AllowedTypes().noVar().noStructParams(!allowStructParams).isValidTypeImpl(type);
}
 
bool isTypeVarFreeType(Type type) { return AllowedTypes().typeVarFree().isValidTypeImpl(type); }
 
AttrConcreteness classifyAttrConcreteness(Attribute attr, bool allowStructParams) {
  if (auto tyAttr = llvm::dyn_cast<TypeAttr>(attr)) {
    return isConcreteType(tyAttr.getValue(), allowStructParams) ? AttrConcreteness::Concrete
                                                                : AttrConcreteness::NonConcrete;
  }
  if (auto intAttr = llvm::dyn_cast<IntegerAttr>(attr)) {
    return isDynamic(intAttr) ? AttrConcreteness::Wildcard : AttrConcreteness::Concrete;
  }
  return llvm::isa<FeltConstAttr>(attr) ? AttrConcreteness::Concrete
                                        : AttrConcreteness::NonConcrete;
}
 
bool hasAffineMapAttr(Type type) { return walkContains<AffineMapAttr>(type); }
 
bool isDynamic(IntegerAttr intAttr) { return ShapedType::isDynamic(fromAPInt(intAttr.getValue())); }
 
ArrayType flattenArrayElementType(ArrayType outerArrTy, Type elementType) {
  SmallVector<Attribute> mergedDims(outerArrTy.getDimensionSizes());
  while (ArrayType nestedArrTy = llvm::dyn_cast<ArrayType>(elementType)) {
    llvm::append_range(mergedDims, nestedArrTy.getDimensionSizes());
    elementType = nestedArrTy.getElementType();
  }
  return ArrayType::get(elementType, mergedDims);
}
 
uint64_t computeEmitEqCardinality(Type type) {
  struct Impl : LLZKTypeSwitch<Impl, uint64_t> {
    uint64_t caseNone(NoneType) { return 0; }
    uint64_t caseBool(IntegerType) { return 1; }
    uint64_t caseIndex(IndexType) { return 1; }
    uint64_t caseFelt(FeltType) { return 1; }
    uint64_t caseArray(ArrayType t) {
      uint64_t elementCardinality = computeEmitEqCardinality(t.getElementType());
      if (elementCardinality == 0) {
        return 0;
      }
      int64_t n = t.getNumElements();
      return llzk::checkedCast<uint64_t>(n) * elementCardinality;
    }
    uint64_t caseStruct(StructType) { llvm_unreachable("not a valid EmitEq type"); }
    uint64_t casePod(PodType t) {
      return std::accumulate(
          t.getRecords().begin(), t.getRecords().end(), 0,
          [](const uint64_t &acc, const RecordAttr &record) {
        return computeEmitEqCardinality(record.getType()) + acc;
      }
      );
    }
    uint64_t caseString(StringType) { llvm_unreachable("not a valid EmitEq type"); }
    uint64_t caseTypeVar(TypeVarType) { llvm_unreachable("tvar has unknown cardinality"); }
    uint64_t caseInvalid(Type) { llvm_unreachable("not a valid LLZK type"); }
  };
  return Impl().match(type);
}
 
namespace {

using AffineInstantiations = DenseMap<std::pair<AffineMapAttr, Side>, IntegerAttr>;
 
struct UnifierImpl {
  ArrayRef<StringRef> rhsRevPrefix;
  UnificationMap *unifications;
  AffineInstantiations *affineToIntTracker;
  bool *staticLhsWithWildcardRhsTracker;
  // This optional function can be used to provide an exception to the standard unification
  // rules and return a true/success result when it otherwise may not.
  llvm::function_ref<bool(Type oldTy, Type newTy)> overrideSuccess;
 
  UnifierImpl(UnificationMap *unificationMap, ArrayRef<StringRef> rhsReversePrefix = {})
      : rhsRevPrefix(rhsReversePrefix), unifications(unificationMap), affineToIntTracker(nullptr),
        staticLhsWithWildcardRhsTracker(nullptr), overrideSuccess(nullptr) {}
 
  UnifierImpl &trackAffineToInt(AffineInstantiations *tracker) {
    this->affineToIntTracker = tracker;
    return *this;
  }
 
  UnifierImpl &trackStaticLhsWithWildcardRhs(bool *tracker) {
    this->staticLhsWithWildcardRhsTracker = tracker;
    return *this;
  }
 
  UnifierImpl &withOverrides(llvm::function_ref<bool(Type oldTy, Type newTy)> overrides) {
    this->overrideSuccess = overrides;
    return *this;
  }

  template <typename Iter1, typename Iter2> bool typeListsUnify(Iter1 lhs, Iter2 rhs) {
    return (lhs.size() == rhs.size()) &&
           std::equal(lhs.begin(), lhs.end(), rhs.begin(), [this](Type a, Type b) {
      return this->typesUnify(a, b);
    });
  }

  bool typeParamsUnify(
      const ArrayRef<Attribute> &lhsParams, const ArrayRef<Attribute> &rhsParams,
      bool unifyDynamicSize = false
  ) {
    auto pred = [this, unifyDynamicSize](auto lhsAttr, auto rhsAttr) {
      return paramAttrUnify(lhsAttr, rhsAttr, unifyDynamicSize);
    };
    return (lhsParams.size() == rhsParams.size()) &&
           std::equal(lhsParams.begin(), lhsParams.end(), rhsParams.begin(), pred);
  }

  bool typeParamsUnify(
      const ArrayAttr &lhsParams, const ArrayAttr &rhsParams, bool unifyDynamicSize = false
  ) {
    ArrayRef<Attribute> emptyParams;
    return typeParamsUnify(
        lhsParams ? lhsParams.getValue() : emptyParams,
        rhsParams ? rhsParams.getValue() : emptyParams, unifyDynamicSize
    );
  }
 
  bool arrayTypesUnify(ArrayType lhs, ArrayType rhs) {
    // Check if the element types of the two arrays can unify
    if (!typesUnify(lhs.getElementType(), rhs.getElementType())) {
      return false;
    }
    // Check if the dimension size attributes unify between the LHS and RHS
    return typeParamsUnify(
        lhs.getDimensionSizes(), rhs.getDimensionSizes(), /*unifyDynamicSize=*/true
    );
  }
 
  bool structTypesUnify(StructType lhs, StructType rhs) {
    LLVM_DEBUG({
      llvm::dbgs() << "[structTypesUnify] lhs = " << lhs << ", rhs = " << rhs << '\n';
    });
    // Check if it references the same StructDefOp, considering the additional RHS path prefix.
    SmallVector<StringRef> rhsNames = getNames(rhs.getNameRef());
    rhsNames.insert(rhsNames.begin(), rhsRevPrefix.rbegin(), rhsRevPrefix.rend());
    auto lhsNames = getNames(lhs.getNameRef());
    if (rhsNames != lhsNames) {
      LLVM_DEBUG({
        llvm::interleaveComma(
            lhsNames, llvm::dbgs() << "[structTypesUnify]   names do not match\n"
                                   << "                         lhsNames = ["
        );
        llvm::interleaveComma(
            rhsNames, llvm::dbgs() << "]\n"
                                   << "                         rhsNames = ["
        );
        llvm::dbgs() << "]\n";
      });
      return false;
    }
    LLVM_DEBUG({ llvm::dbgs() << "[structTypesUnify]   checking unification of parameters\n"; });
    // Check if the parameters unify between the LHS and RHS
    return typeParamsUnify(lhs.getParams(), rhs.getParams(), /*unifyDynamicSize=*/false);
  }
 
  bool podTypesUnify(PodType lhs, PodType rhs) {
    // Same number of records, with the same names in the same order and record types unify.
    auto lhsRecords = lhs.getRecords();
    auto rhsRecords = rhs.getRecords();
 
    return lhsRecords.size() == rhsRecords.size() &&
           llvm::all_of(llvm::zip_equal(lhsRecords, rhsRecords), [this](auto &&records) {
      auto &&[lhsRecord, rhsRecord] = records;
      return lhsRecord.getName() == rhsRecord.getName() &&
             typesUnify(lhsRecord.getType(), rhsRecord.getType());
    });
  }
 
  bool functionTypesUnify(FunctionType lhs, FunctionType rhs) {
    return typeListsUnify(lhs.getInputs(), rhs.getInputs()) &&
           typeListsUnify(lhs.getResults(), rhs.getResults());
  }
 
  bool typesUnify(Type lhs, Type rhs) {
    if (lhs == rhs) {
      // Equal syntax in an included signature still refers to the included namespace.
      if (!rhsRevPrefix.empty()) {
        if (auto lhsStruct = llvm::dyn_cast<StructType>(lhs)) {
          return structTypesUnify(lhsStruct, llvm::cast<StructType>(rhs));
        }
        if (auto lhsArray = llvm::dyn_cast<ArrayType>(lhs)) {
          return arrayTypesUnify(lhsArray, llvm::cast<ArrayType>(rhs));
        }
        if (auto lhsPod = llvm::dyn_cast<PodType>(lhs)) {
          return podTypesUnify(lhsPod, llvm::cast<PodType>(rhs));
        }
        if (auto lhsFunction = llvm::dyn_cast<FunctionType>(lhs)) {
          return functionTypesUnify(lhsFunction, llvm::cast<FunctionType>(rhs));
        }
      }
      return true;
    }
    if (overrideSuccess && overrideSuccess(lhs, rhs)) {
      return true;
    }
    // A type variable can be any type, thus it unifies with anything.
    if (TypeVarType lhsTvar = llvm::dyn_cast<TypeVarType>(lhs)) {
      track(Side::LHS, lhsTvar.getNameRef(), rhs);
      return true;
    }
    if (TypeVarType rhsTvar = llvm::dyn_cast<TypeVarType>(rhs)) {
      track(Side::RHS, rhsTvar.getNameRef(), lhs);
      return true;
    }
    if (llvm::isa<StructType>(lhs) && llvm::isa<StructType>(rhs)) {
      return structTypesUnify(llvm::cast<StructType>(lhs), llvm::cast<StructType>(rhs));
    }
    if (llvm::isa<ArrayType>(lhs) && llvm::isa<ArrayType>(rhs)) {
      return arrayTypesUnify(llvm::cast<ArrayType>(lhs), llvm::cast<ArrayType>(rhs));
    }
    if (llvm::isa<PodType>(lhs) && llvm::isa<PodType>(rhs)) {
      return podTypesUnify(llvm::cast<PodType>(lhs), llvm::cast<PodType>(rhs));
    }
    if (llvm::isa<FunctionType>(lhs) && llvm::isa<FunctionType>(rhs)) {
      return functionTypesUnify(llvm::cast<FunctionType>(lhs), llvm::cast<FunctionType>(rhs));
    }
    return false;
  }
 
private:
  template <typename Tracker, typename Key, typename Val>
  inline void track(Tracker &tracker, Side side, Key keyHead, Val val) {
    auto key = std::make_pair(keyHead, side);
    auto it = tracker.find(key);
    if (it == tracker.end()) {
      tracker.try_emplace(key, val);
    } else if (it->getSecond() != val) {
      it->second = nullptr;
    }
  }
 
  void track(Side side, SymbolRefAttr symRef, Type ty) {
    if (unifications) {
      Attribute attr;
      if (TypeVarType tvar = dyn_cast<TypeVarType>(ty)) {
        // If 'ty' is TypeVarType<@S>, just map to @S directly.
        attr = tvar.getNameRef();
      } else {
        // Otherwise wrap as a TypeAttr.
        attr = TypeAttr::get(ty);
      }
      assert(symRef);
      assert(attr);
      track(*unifications, side, symRef, attr);
    }
  }
 
  void track(Side side, SymbolRefAttr symRef, Attribute attr) {
    if (unifications) {
      // If 'attr' is TypeAttr<TypeVarType<@S>>, just map to @S directly.
      if (TypeAttr tyAttr = dyn_cast<TypeAttr>(attr)) {
        if (TypeVarType tvar = dyn_cast<TypeVarType>(tyAttr.getValue())) {
          attr = tvar.getNameRef();
        }
      }
      assert(symRef);
      assert(attr);
      // If 'attr' is a SymbolRefAttr, map in both directions for the correctness of
      // `isMoreConcreteUnification()` which relies on RHS check while other external
      // checks on the UnificationMap may do LHS checks, and in the case of both being
      // SymbolRefAttr, unification in either direction is possible.
      if (SymbolRefAttr otherSymAttr = dyn_cast<SymbolRefAttr>(attr)) {
        track(*unifications, reverse(side), otherSymAttr, symRef);
      }
      track(*unifications, side, symRef, attr);
    }
  }
 
  void track(Side side, AffineMapAttr affineAttr, IntegerAttr intAttr) {
    if (affineToIntTracker) {
      assert(affineAttr);
      assert(intAttr);
      assert(!isDynamic(intAttr));
      track(*affineToIntTracker, side, affineAttr, intAttr);
    }
  }
 
  bool paramAttrUnify(Attribute lhsAttr, Attribute rhsAttr, bool unifyDynamicSize = false) {
    assertValidAttrForParamOfType(lhsAttr);
    assertValidAttrForParamOfType(rhsAttr);
    // Straightforward equality check.
    if (lhsAttr == rhsAttr) {
      if (!rhsRevPrefix.empty()) {
        if (auto lhsType = llvm::dyn_cast<TypeAttr>(lhsAttr)) {
          return typesUnify(lhsType.getValue(), llvm::cast<TypeAttr>(rhsAttr).getValue());
        }
      }
      return true;
    }
    // AffineMapAttr can unify with IntegerAttr (other than kDynamic) because struct parameter
    // instantiation will result in conversion of AffineMapAttr to IntegerAttr.
    if (AffineMapAttr lhsAffine = llvm::dyn_cast<AffineMapAttr>(lhsAttr)) {
      if (IntegerAttr rhsInt = llvm::dyn_cast<IntegerAttr>(rhsAttr)) {
        if (!isDynamic(rhsInt)) {
          track(Side::LHS, lhsAffine, rhsInt);
          return true;
        }
      }
    }
    if (AffineMapAttr rhsAffine = llvm::dyn_cast<AffineMapAttr>(rhsAttr)) {
      if (IntegerAttr lhsInt = llvm::dyn_cast<IntegerAttr>(lhsAttr)) {
        if (!isDynamic(lhsInt)) {
          track(Side::RHS, rhsAffine, lhsInt);
          return true;
        }
      }
    }
    // If either side is ShapedType::kDynamic then, similarly to Symbols, assume they unify.
    // NOTE: Dynamic array dimensions (i.e. '?') are allowed in LLZK but should generally be
    // restricted to scenarios where it can be replaced with a concrete value during the flattening
    // pass, such as a `unifiable_cast` where the other side of the cast has concrete dimensions or
    // extern functions with varargs.
    if (unifyDynamicSize) {
      auto dyn_cast_if_dynamic = [](Attribute attr) -> IntegerAttr {
        if (IntegerAttr intAttr = llvm::dyn_cast<IntegerAttr>(attr)) {
          if (isDynamic(intAttr)) {
            return intAttr;
          }
        }
        return nullptr;
      };
      auto is_const_like = [](Attribute attr) {
        return llvm::isa_and_present<IntegerAttr, SymbolRefAttr, AffineMapAttr>(attr);
      };
      if (IntegerAttr lhsIntAttr = dyn_cast_if_dynamic(lhsAttr)) {
        if (is_const_like(rhsAttr)) {
          return true;
        }
      }
      if (IntegerAttr rhsIntAttr = dyn_cast_if_dynamic(rhsAttr)) {
        if (is_const_like(lhsAttr)) {
          if (staticLhsWithWildcardRhsTracker) {
            *staticLhsWithWildcardRhsTracker = true;
          }
          return true;
        }
      }
    }
    // If either side is a SymbolRefAttr, assume they unify because either flattening or a pass with
    // a more involved value analysis is required to check if they are actually the same value.
    if (SymbolRefAttr lhsSymRef = llvm::dyn_cast<SymbolRefAttr>(lhsAttr)) {
      track(Side::LHS, lhsSymRef, rhsAttr);
      return true;
    }
    if (SymbolRefAttr rhsSymRef = llvm::dyn_cast<SymbolRefAttr>(rhsAttr)) {
      track(Side::RHS, rhsSymRef, lhsAttr);
      return true;
    }
    // If both are type refs, check for unification of the types.
    if (TypeAttr lhsTy = llvm::dyn_cast<TypeAttr>(lhsAttr)) {
      if (TypeAttr rhsTy = llvm::dyn_cast<TypeAttr>(rhsAttr)) {
        return typesUnify(lhsTy.getValue(), rhsTy.getValue());
      }
    }
    // Otherwise, they do not unify.
    return false;
  }
};
 
} // namespace
 
bool typeParamsUnify(
    const ArrayRef<Attribute> &lhsParams, const ArrayRef<Attribute> &rhsParams,
    UnificationMap *unifications
) {
  return UnifierImpl(unifications).typeParamsUnify(lhsParams, rhsParams);
}

bool typeParamsUnify(
    const ArrayAttr &lhsParams, const ArrayAttr &rhsParams, UnificationMap *unifications
) {
  return UnifierImpl(unifications).typeParamsUnify(lhsParams, rhsParams);
}
 
bool arrayTypesUnify(
    ArrayType lhs, ArrayType rhs, ArrayRef<StringRef> rhsReversePrefix, UnificationMap *unifications
) {
  return UnifierImpl(unifications, rhsReversePrefix).arrayTypesUnify(lhs, rhs);
}
 
bool structTypesUnify(
    StructType lhs, StructType rhs, ArrayRef<StringRef> rhsReversePrefix,
    UnificationMap *unifications
) {
  return UnifierImpl(unifications, rhsReversePrefix).structTypesUnify(lhs, rhs);
}
 
bool podTypesUnify(
    PodType lhs, PodType rhs, ArrayRef<StringRef> rhsReversePrefix, UnificationMap *unifications
) {
  return UnifierImpl(unifications, rhsReversePrefix).podTypesUnify(lhs, rhs);
}
 
bool functionTypesUnify(
    FunctionType lhs, FunctionType rhs, ArrayRef<StringRef> rhsReversePrefix,
    UnificationMap *unifications
) {
  return UnifierImpl(unifications, rhsReversePrefix).functionTypesUnify(lhs, rhs);
}
 
bool typesUnify(
    Type lhs, Type rhs, ArrayRef<StringRef> rhsReversePrefix, UnificationMap *unifications
) {
  return UnifierImpl(unifications, rhsReversePrefix).typesUnify(lhs, rhs);
}
 
bool isMoreConcreteUnification(
    Type oldTy, Type newTy, llvm::function_ref<bool(Type oldTy, Type newTy)> knownOldToNew
) {
  UnificationMap unifications;
  AffineInstantiations affineInstantiations;
  bool staticLhsBecomesWildcardRhs = false;
  // Run type unification with the addition that affine map can become integer in the new type.
  if (!UnifierImpl(&unifications)
           .trackAffineToInt(&affineInstantiations)
           .trackStaticLhsWithWildcardRhs(&staticLhsBecomesWildcardRhs)
           .withOverrides(knownOldToNew)
           .typesUnify(oldTy, newTy)) {
    return false;
  }
 
  // If a statically-known LHS value becomes a wildcard in the RHS, it is not more concrete.
  if (staticLhsBecomesWildcardRhs) {
    return false;
  }
 
  // If either map contains RHS-keyed mappings then the old type is more concrete than the new. In
  // the UnificationMap, a RHS key would indicate that the new type contains a SymbolRef (i.e. the
  // second-least concrete attribute kind, only to wildcard which was checked above) where the old
  // type contained some other attribute. In the AffineInstantiations map, a RHS key would indicate
  // that the new type contains an AffineMapAttr where the old type contains an IntegerAttr.
  auto entryIsRHS = [](const auto &entry) { return entry.first.second == Side::RHS; };
  return !llvm::any_of(unifications, entryIsRHS) && !llvm::any_of(affineInstantiations, entryIsRHS);
}
 
FailureOr<IntegerAttr> forceIntType(IntegerAttr attr, EmitErrorFn emitError) {
  if (llvm::isa<IndexType>(attr.getType())) {
    return attr;
  }
  // Ensure the APInt is the right bitwidth for IndexType or else
  // IntegerAttr::verify(..) will report an error.
  APInt value = attr.getValue();
  auto compare = value.getBitWidth() <=> IndexType::kInternalStorageBitWidth;
  if (compare < 0) {
    value = attr.getType().isSignedInteger() ? value.sext(IndexType::kInternalStorageBitWidth)
                                             : value.zext(IndexType::kInternalStorageBitWidth);
  } else if (compare > 0) {
    // The source integer type may be wider than index storage even when its value is
    // representable. Signed values need a signed representability check: getActiveBits()
    // treats their two's-complement representation as unsigned, rejecting negative values
    // and accepting some out-of-range positive values after truncation.
    bool isRepresentable = attr.getType().isSignedInteger()
                               ? value.isSignedIntN(IndexType::kInternalStorageBitWidth)
                               : value.isIntN(IndexType::kInternalStorageBitWidth);
    if (!isRepresentable) {
      return emitError().append("value is too large for `index` type: ", debug::toStringOne(value));
    }
    value = value.trunc(IndexType::kInternalStorageBitWidth);
  }
  return IntegerAttr::get(IndexType::get(attr.getContext()), value);
}
 
FailureOr<Attribute> forceIntAttrType(Attribute attr, EmitErrorFn emitError) {
  if (IntegerAttr intAttr = llvm::dyn_cast_if_present<IntegerAttr>(attr)) {
    return forceIntType(intAttr, emitError);
  }
  return attr;
}
 
FailureOr<SmallVector<Attribute>>
forceIntAttrTypes(ArrayRef<Attribute> attrList, EmitErrorFn emitError) {
  SmallVector<Attribute> result;
  for (Attribute attr : attrList) {
    FailureOr<Attribute> forced = forceIntAttrType(attr, emitError);
    if (failed(forced)) {
      return failure();
    }
    result.push_back(*forced);
  }
  return result;
}
 
LogicalResult verifyIntAttrType(EmitErrorFn emitError, Attribute in) {
  if (IntegerAttr intAttr = llvm::dyn_cast_if_present<IntegerAttr>(in)) {
    Type attrTy = intAttr.getType();
    if (!AllowedTypes().onlyInt().isValidTypeImpl(attrTy)) {
      if (emitError) {
        emitError()
            .append("IntegerAttr must have type 'index' or 'i1' but found '", attrTy, '\'')
            .report();
      }
      return failure();
    }
  }
  return success();
}
 
LogicalResult verifyAffineMapAttrType(EmitErrorFn emitError, Attribute in) {
  if (AffineMapAttr affineAttr = llvm::dyn_cast_if_present<AffineMapAttr>(in)) {
    AffineMap map = affineAttr.getValue();
    if (map.getNumResults() != 1) {
      if (emitError) {
        emitError()
            .append(
                "AffineMapAttr must yield a single result, but found ", map.getNumResults(),
                " results"
            )
            .report();
      }
      return failure();
    }
  }
  return success();
}
 
LogicalResult verifyStructTypeParams(EmitErrorFn emitError, ArrayAttr params) {
  return success(AllowedTypes().areValidStructTypeParams(params, emitError));
}
 
LogicalResult verifyArrayDimSizes(EmitErrorFn emitError, ArrayRef<Attribute> dimensionSizes) {
  return success(AllowedTypes().areValidArrayDimSizes(dimensionSizes, emitError));
}
 
LogicalResult
verifyArrayType(EmitErrorFn emitError, Type elementType, ArrayRef<Attribute> dimensionSizes) {
  return success(AllowedTypes().isValidArrayTypeImpl(elementType, dimensionSizes, emitError));
}
 
void assertValidAttrForParamOfType(Attribute attr) {
  // Must be the union of valid attribute types within ArrayType, StructType, and TypeVarType.
  using TypeVarAttrs = TypeList<SymbolRefAttr>; // per ODS spec of TypeVarType
  if (!TypeListUnion<ArrayDimensionTypes, StructParamTypes, TypeVarAttrs>::matches(attr)) {
    llvm::report_fatal_error(
        "Legal type parameters are inconsistent. Encountered " +
        attr.getAbstractAttribute().getName()
    );
  }
}
 
LogicalResult
verifySubArrayType(EmitErrorFn emitError, ArrayType arrayType, ArrayType subArrayType) {
  ArrayRef<Attribute> dimsFromArr = arrayType.getDimensionSizes();
  size_t numArrDims = dimsFromArr.size();
  ArrayRef<Attribute> dimsFromSubArr = subArrayType.getDimensionSizes();
  size_t numSubArrDims = dimsFromSubArr.size();
 
  if (numArrDims < numSubArrDims) {
    return emitError().append(
        "subarray type ", subArrayType, " has more dimensions than array type ", arrayType
    );
  }
 
  size_t toDrop = numArrDims - numSubArrDims;
  ArrayRef<Attribute> dimsFromArrReduced = dimsFromArr.drop_front(toDrop);
 
  // Ensure dimension sizes are compatible (ignoring the indexed dimensions)
  if (!typeParamsUnify(dimsFromArrReduced, dimsFromSubArr)) {
    std::string message;
    llvm::raw_string_ostream ss(message);
    auto appendOne = [&ss](Attribute a) { appendWithoutType(ss, a); };
    ss << "cannot unify array dimensions [";
    llvm::interleaveComma(dimsFromArrReduced, ss, appendOne);
    ss << "] with [";
    llvm::interleaveComma(dimsFromSubArr, ss, appendOne);
    ss << "]";
    return emitError().append(message);
  }
 
  // Ensure element types of the arrays are compatible
  if (!typesUnify(arrayType.getElementType(), subArrayType.getElementType())) {
    return emitError().append(
        "incorrect array element type; expected: ", arrayType.getElementType(),
        ", found: ", subArrayType.getElementType()
    );
  }
 
  return success();
}
 
LogicalResult
verifySubArrayOrElementType(EmitErrorFn emitError, ArrayType arrayType, Type subArrayOrElemType) {
  if (auto subArrayType = llvm::dyn_cast<ArrayType>(subArrayOrElemType)) {
    return verifySubArrayType(emitError, arrayType, subArrayType);
  }
  if (!typesUnify(arrayType.getElementType(), subArrayOrElemType)) {
    return emitError().append(
        "incorrect array element type; expected: ", arrayType.getElementType(),
        ", found: ", subArrayOrElemType
    );
  }
 
  return success();
}
 
bool isFeltOrSimpleFeltAggregate(Type ty) {
  return TypeSwitch<Type, bool>(ty)
      .Case<FeltType>([](auto) { return true; })
      .Case<ArrayType>([](auto arrTy) {
    return isFeltOrSimpleFeltAggregate(arrTy.getElementType());
  })
      .Case<PodType>([](auto podTy) {
    for (auto record : podTy.getRecords()) {
      if (!isFeltOrSimpleFeltAggregate(record.getType())) {
        return false;
      }
    }
    return true;
  }).Default([](auto) { return false; });
}
 
bool isValidMainSignalType(Type pType) {
  if (auto arrayParamTy = llvm::dyn_cast<ArrayType>(pType)) {
    return llvm::isa<FeltType>(arrayParamTy.getElementType());
  }
  return llvm::isa<FeltType>(pType);
}
 
} // namespace llzk